Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] Sort coo to build correct csr format sparse matrix on GPU #6050

Merged
merged 3 commits into from
Sep 17, 2022

Conversation

FantasyVR
Copy link
Collaborator

Related issue = #2906

When building a coo format sparse matrix, the indices are not in order. To build a valid csr format sparse matrix. We need to first sort the coo indices arrays.

@netlify
Copy link

netlify bot commented Sep 13, 2022

Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit b24aee4
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/632355a4b3d1ec0008970b62

Copy link
Contributor

@Hanke98 Hanke98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job! I only have two little questions:

taichi/program/sparse_matrix.cpp Show resolved Hide resolved
taichi/program/sparse_matrix.cpp Show resolved Hide resolved
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FantasyVR FantasyVR merged commit 33a606a into taichi-dev:master Sep 17, 2022
@FantasyVR FantasyVR deleted the coo_sorting branch November 23, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants